Accept double-quotes, comments in selectors #53
Conversation
Change lookAheadNotOpenBracePattern to allow selectors to match "" patterns (eg [class="span"]) and selectors with comments interspersed. This fixes issue wikimedia#35, where text before either comments or attribute selectors using double quotes were not being considered part of the selector, and having text flipped as though they were part of rules. (Eg `.right [class="span"] { float: right; }` was flipped to `.left` .)
|
Thanks! |
Add tests for "leave class names alone" to work when selector includes either comments or attribute selectors with double quotes.
| colorPattern = '(#?' + nmcharPattern + '+|(?:rgba?|hsla?)\\([ \\d.,%-]+\\))', | ||
| urlCharsPattern = '(?:' + urlSpecialCharsPattern + '|' + nonAsciiPattern + '|' + escapePattern + ')*', | ||
| lookAheadNotLetterPattern = '(?![a-zA-Z])', | ||
| lookAheadNotOpenBracePattern = '(?!(' + nmcharPattern + '|\\r?\\n|\\s|#|\\:|\\.|\\,|\\+|>|\\(|\\)|\\[|\\]|=|\\*=|~=|\\^=|\'[^\']*\'])*?{)', |
There was a problem hiding this comment.
Can you explain the removal of the closing square bracket ] from the original line? Actually, I'm unsure as to why it what was there, but would be good to confirm whether its removal was important to this change, or just clean up, or something else.
There was a problem hiding this comment.
I don't actually remember the reason for that, but I can guess.
Presumably, the original purpose of the ] was to ensure that the quotes were specifically part of simple attribute selector values, like [class='span'] ('] at the end), which are by far the most common use of quotes in selectors. However, this prevents it from matching other types of quotes in selectors, such as :lang("en") and [class='span' i]. (Currently, both have some browser support and are in Working Draft state of the spec.)
BenchmarkBefore: After: |
Change lookAheadNotOpenBracePattern to allow selectors to match "" patterns (eg [class="span"]) and selectors with comments interspersed. This fixes issue #35, where text before either comments or attribute selectors using double quotes were not being considered part of the selector, and having text flipped as though they were part of rules. (Eg
.right [class="span"] { float: right; }was flipped to.left.)